User Login    
 + Register
Bookmark and Share
  • Main navigation
Login
Username:

Password:

Remember me



Lost Password?

Register now!





(1) 2 »


Re: Messing with textsanitizer and koivi editor
Just can't stay away
rank4823bd1d117e3.gif
Joined:
2004/3/19 13:08
Group:
Registered Users
Forge Developers
Posts: 128
I think is enough.
Thk's for all.

Posted on: 2004/9/25 16:05
_MD_TRANSFER_DESC _MD_TRANSFER


Re: Messing with textsanitizer and koivi editor
Home away from home
rank4823bd3e90096.gif
Joined:
2003/11/21 8:08
From Copenhagen, Denmark
Group:
Forge Developers
Registered Users
Posts: 841
So an additional parameter to disable the makeClickable method call would be enough?

Posted on: 2004/9/25 16:02
_________________
Knowledge = Power
Power = Energy
Energy = Matter
Matter = Mass
So a good bookshop is really just a genteel black hole, which knows how to read
---
Consulting
ShowCase
_MD_TRANSFER_DESC _MD_TRANSFER


Re: Messing with textsanitizer and koivi editor
Just can't stay away
rank4823bd1d117e3.gif
Joined:
2004/3/19 13:08
Group:
Registered Users
Forge Developers
Posts: 128
There was a problem with smileys too but I have solved it yet.

So the only problem with textsanitizer is the makeclicable function

Posted on: 2004/9/25 15:49
_MD_TRANSFER_DESC _MD_TRANSFER


Re: Messing with textsanitizer and koivi editor
Home away from home
rank4823bd3e90096.gif
Joined:
2003/11/21 8:08
From Copenhagen, Denmark
Group:
Forge Developers
Registered Users
Posts: 841
Hmmm - so it's the conversion of urls to hyperlinks that breaks the code?

Would leaving out this in the displayTarea() method be a solution:
$text =& $this->makeClickable($text);


Then we can maybe add another parameter to the method for makeClickable - which defaults to yes, but can be overridden by e.g. the koiviEditor class.

Posted on: 2004/9/25 15:09
_________________
Knowledge = Power
Power = Energy
Energy = Matter
Matter = Mass
So a good bookshop is really just a genteel black hole, which knows how to read
---
Consulting
ShowCase
_MD_TRANSFER_DESC _MD_TRANSFER


Re: Messing with textsanitizer and koivi editor
Just can't stay away
rank4823bd1d117e3.gif
Joined:
2004/3/19 13:08
Group:
Registered Users
Forge Developers
Posts: 128
New combination.
For example, now it takes links like
http://ww.example.com

and transforms with
<a href=http://ww.example.com >


But if I put a image
<img src=http://ww.example.com/1.gif />


It does:
<img src=<a href=http://ww.example.com > />


It breaks the code...

So I think is usefull to apply only some patterns and not all.
Is really difficult to make a script for closing orphan tags without DOM manipulation.
I've seen some php tidy scripts but only run under php 4.4 or upper.
For my editor I make some cleanup before sending, it's not perfect but removes useless tags and other garbage.

Posted on: 2004/9/25 15:02
_MD_TRANSFER_DESC _MD_TRANSFER


Re: Messing with textsanitizer and koivi editor
Home away from home
rank4823bd3e90096.gif
Joined:
2003/11/21 8:08
From Copenhagen, Denmark
Group:
Forge Developers
Registered Users
Posts: 841
What kind of sanitation is necessary? Does it need sanitation not present in the MyTextSanitizer class? Or just a new combination of the sanitation methods?

Any additions that do not destroy backwards compatibility, I'll implement in the core, no problem.

Posted on: 2004/9/25 14:28
_________________
Knowledge = Power
Power = Energy
Energy = Matter
Matter = Mass
So a good bookshop is really just a genteel black hole, which knows how to read
---
Consulting
ShowCase
_MD_TRANSFER_DESC _MD_TRANSFER


Re: Messing with textsanitizer and koivi editor
Just can't stay away
rank4823bd1d117e3.gif
Joined:
2004/3/19 13:08
Group:
Registered Users
Forge Developers
Posts: 128
I have problems with news and newbb koivi integration, both use textsanitizer and in both the problem is solved if I comment some lines into textsanitizer class. (As you can see in test site, I have changed the sanitizer class and I have no problems with news module)

Wfsections must be different because is preparate to use a wysiwyg editor.
But I don't like the idea of making changes in the modules code for avoiding problems with sanitizer class.

There are some solutions:
-Add to sanitizer class a method like ShowTextareaForWysiwyg or something like that.
Problem: We are changing a core file.
Advantage: Integration of editors is easiest.

-Change the code to use some tags like bbcode.
Advantge: No core changes.
Problems: We replace to replace again. We must change the rich text editors code to fit with this.

There is no problem with koivi (I hope) but think about other editors like fck or htmlarea.

@Frankblack
I think I have posted a news in test site with todo and made tasks.

For 1.0 version I'll implement:
-Advanced image,table and url dialogs (with anchor too), words count, Spellcheck, Toggle table borders, e.t.c

By now I think is not possible to call spellbound spellcheck with javascript (you must press with right click on textfield to spellcheck).

In one or two days I'll publish it. All other requests will be for the next version. (Let me finish the v1.0 please :-D )

@Mith
I'm excited with the idea. Cooool

@Pred
Sorry for not helping you with newbb, I'm all the time with the editor. I'll try to find a intermediate solution for avoiding problems with newbb integration.

Posted on: 2004/9/25 12:16
_MD_TRANSFER_DESC _MD_TRANSFER


Re: Messing with textsanitizer and koivi editor
Home away from home
rank4823bd3e90096.gif
Joined:
2003/11/21 8:08
From Copenhagen, Denmark
Group:
Forge Developers
Registered Users
Posts: 841
My take on this is NOT to make this a module, but to make a wysiwyg folder in the core, comparable to the themes folder, with ./wysiwyg/koivi, ./wysiwyg/spaw etc.

This means that it will not just be a XoopsForm class, mixed with the other XoopsForm classes in class/xoopsform, but a special one.

The XOOPS core administration will be changed to accomodate the configuration options - however, we may have to add it as both a class AND a module to account for koivi-specific configuration options, which are not there for e.g. spaw and htmlarea.

I would very much like to work with you on this one, Samuels, to get the editor well integrated into XOOPS, while still maintaining a modular approach.

Posted on: 2004/9/25 8:35
_________________
Knowledge = Power
Power = Energy
Energy = Matter
Matter = Mass
So a good bookshop is really just a genteel black hole, which knows how to read
---
Consulting
ShowCase
_MD_TRANSFER_DESC _MD_TRANSFER


Re: Messing with textsanitizer and koivi editor
Home away from home
rank4823bd3e90096.gif
Joined:
2003/10/27 13:40
From Germany
Group:
Registered Users
Posts: 458
Quote:

frankblack wrote:
Quote:
-Second one, textsanitizer destroys the html code when displays it.


Really? I implemented Editor into wfsection and I wrote hundreds!! of articles without any problem.



Joe have ever tried it with the newbb? I have tried it and the display of the html code was destroyed ( Preview works, there is no use of templates, view in the Post looks messed up ).

If this problem is solved i would love to add the editor to the newbb ;-)



Posted on: 2004/9/25 7:35
_________________
Predator

- Time is a created thing. To say, "I don't have time" is like saying "I don't want to."
Lao-Tzu...
_MD_TRANSFER_DESC _MD_TRANSFER


Re: Messing with textsanitizer and koivi editor
Home away from home
rank4823bd3e90096.gif
Joined:
2003/11/19 13:01
From Willich, Germany
Group:
Forge Developers
Registered Users
Posts: 156
Quote:
-Second one, textsanitizer destroys the html code when displays it.


Really? I implemented Editor into wfsection and I wrote hundreds!! of articles without any problem.

Quote:
-Third, I don't know how to do an admin interface without making a module.
-Any way to use smarty without making a module with the editor?
-Do you prefer koivi as a simple class or like a module?


Make a module! So everyone can select which editor to be installed.

If a few features more are added to Koivi it will be the best one.
- adding special chars
- adding date/time
- image properties
- more options on inserting links
- make the templates editor work with Koivi
- cleaning up the code when switching to html source. now the code will appear as one line

A few bugs:
- When choosing size from dropdown the size is still selected so you have to jump between the sizes when formatting other text
- missing weight and height for images
- i am not sure if this is a bug: when images are inserted they have the current url to the image. but when you want to move your xoops to another server/address all the image urls have to be changed

Posted on: 2004/9/25 6:42
_________________
greetz
frankblack
_MD_TRANSFER_DESC _MD_TRANSFER




(1) 2 »



You can view topic.
You cannot start a new topic.
You cannot reply to posts.
You cannot edit your posts.
You cannot delete your posts.
You cannot add new polls.
You cannot vote in polls.
You cannot attach files to posts.
You cannot post without approval.
You cannot use topic type.
You cannot use HTML syntax.
You cannot use signature.
You cannot create pdf.
You cannot get print page.

[Advanced Search]